Adds pygame recipe #2164
Merged
Adds pygame recipe #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
opacam
previously approved these changes
May 1, 2020
There was a problem hiding this comment.
👍 thanks @robertpfeiffer and @AndreMiras
I'm wondering if we should write docstring describing a little the recipe (just to avoid confusion with old pygame bootstrap). Also I would include part of the text you wrote at PR description...maybe inside a warning ref:
Some pygame functionality is still untested,
and some dependencies like freetype, postmidi and libjpeg are currently not part of the build. It's usable, but not complete.
Comment on lines
1
to
4
| from pythonforandroid.recipe import CompiledComponentsPythonRecipe | ||
| from os.path import join | ||
| from pythonforandroid.toolchain import current_directory |
There was a problem hiding this comment.
nitpick: Maybe we can sort the imports
There was a problem hiding this comment.
Addressed, I wish we were linting using isort across the code base
As discussed on the Discord, this is a recipe to build apps based on SDL2-based pygame. It currently references a RC until we have an official stable release of pygame based on SDL2 with android support. Simple examples have been tested by other pygame users (it doesn't just build on my own machine) but some pygame functionality is still untested, and some dependencies like freetype, postmidi and libjpeg are currently not part of the build. It's usable, but not complete.
AndreMiras
force-pushed
the
feature/pygame_recipe
branch
from
b20fbaf
to
9dded87
Compare
|
Addressed the docstring and iport sorting. I've also updated the commit message as we no longer reference a moving branch but a release candidate |
|
Looks good to me, I think. I'll make another PR after the next pygame dev release. |
|
Thanks for the feedback and for the effort, merging 🚀 |
lerela
added a commit
to chronolife-rd/python-for-android
that referenced
this pull request
Jun 23, 2020
🔖 v2020.06.02 * Adds missing requests sub dependencies (kivy#2221) * Bumps to Gradle 6.4.1 (kivy#2222) * Bumps to Cython==0.29.19 (kivy#2220) * Updates install and troubleshooting docs (kivy#2219) * Bumps to Ubuntu 20.04 (kivy#2218) * Attempt to improve the issue template (kivy#2217) * Add `opencv_extras` recipe (kivy#2209) * Split logic for build modes & debug symbols (kivy#2213) * Troubleshoot SSL error (kivy#2205) * Remove superfluous recipes fixes (kivy#2202) * Add tests for hostpython3 recipe (kivy#2196) * Fix for 'cannot find setuptools module' (kivy#2195) * Rename `Hostpython3Recipe` class to camel case (kivy#2194) * Fix `test_should_build` (kivy#2193) * Add initial tests for python3 recipe (kivy#2192) * PythonActivityUtil helper for unpacking data (kivy#2189) * Fixes flake8 errors post update (kivy#2191) * Share PythonUtil.java between bootstraps (kivy#2188) * Java code linting using PMD 6.23.0 (kivy#2187) * Deletes deprecated renpy Python{Activity,Service}.java (kivy#2186) * Removes java concurrency/ folder (kivy#2185) * Reuse common AssetExtract.java (kivy#2182) * Use common Hardware.java (kivy#2183) * Moves kamranzafar/ java directory to common/ (kivy#2184) * Updates release documentation (kivy#2177) * Fixes service only unittest loading (kivy#2181) * Narrows some context manager scopes (kivy#2179) * Downgrades to SDL2 2.0.9 (kivy#2180) * Bump to SDL2 2.0.10 & extract .java from SDL2 tarball (kivy#2113) * Adds pygame recipe (kivy#2164) * Adds macOS install instructions (2165) * Removed python2 support mention from README (kivy#2162) * Adding more assets (kivy#2132) * Get --add-source working for dirs in Gradle builds (kivy#2156) * Fixes python build with macOS venv (kivy#2159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: this authored by @robertpfeiffer I've just copy/pasted his description in the commit message, rebased and made few edits to give an example of what the PR could look like.
As discussed on the Discord, this is a recipe to build apps based on
SDL2-based pygame.
It currently references https://github.com/pygame/pygame/tree/android,
a branch that will continue to live until we have an official stable
release of pygame based on SDL2 with android support.
Simple examples have been tested by other pygame users (it doesn't just
build on my own machine) but some pygame functionality is still untested,
and some dependencies like freetype, postmidi and libjpeg are currently
not part of the build. It's usable, but not complete.