Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install already compiled libraries #2127

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

robertpfeiffer
Copy link
Contributor

If a library is already compiled, skip compilation, but don't skip actually installing the thing.

@robertpfeiffer robertpfeiffer changed the title fixes #2056, fixes #2045, actually fixes #2051 and #1142 Install already compiled libraries Apr 3, 2020
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thank you. In theory it would be best to have a regression test for this so it doesn't happen again.
Are you up for it?

@AndreMiras AndreMiras merged commit 7a983f4 into kivy:develop Apr 3, 2020
@AndreMiras
Copy link
Member

The coveralls build fails since a couple of days now and it's not related to this PR, so I'm merging.
Thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants