Skip to content

Fixes code block directives #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fixes code block directives #2126

merged 1 commit into from
Apr 6, 2020
+45 −45

Conversation

AndreMiras
Copy link
Member

  • s/codeblock/code-block/
  • fixes code block being nested because of previous literal block ::

See screenshot attached, to the left before the change, to the right after the change:
image

@AndreMiras
Fixes code block directives
a69a2c4 
- s/codeblock/code-block/
- fixes code block being nested because of previous literal block `::`
opacam
opacam approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!!

Note: I see the tox tests failing with coveralls error, but this is solved at #2119, which is not included in here and already merged into develop branch, so we should be fine 👍

@AndreMiras
Copy link
Member Author

Yes indeed I didn't rebase that one. In theory I should, but I'll simply merge instead 😛
Thanks for the review

@AndreMiras AndreMiras merged commit cfabe37 into kivy:develop Apr 6, 2020
@AndreMiras AndreMiras deleted the feature/rst_documentation_fixes branch April 6, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opacam opacam opacam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreMiras @opacam