Playing with `on_device_unit_test_app` #2046 - Episode II #2088

opacam · 2020-03-17T21:54:34Z

This is not to be reviewed nor merged, of course commented if you want, but the purpose of this is to play a little more with some new recipes and the on_device_unit_test_app (#2046)...so I understand this as some kind of continuation of #2076 (just to have a new start point with the current develop branch).

I'm not sure if we have to include all the changes I advance to you in here, but sure that there are some new recipes that can be very useful. I made this to make it work mplfinance, a kind of matplotlib's extension. To do so I faced several issues along the way, which forced me to introduce a couple of libraries that will allow us to build some python compiled modules that currently aren't compiled: _bz2.cpython-38.so and _lzma.cpython-38.so. Also I was forced to create a Pandas recipe...this one is interesting right?

Anyway, If you guys find this interesting, I will create separate PRs...so give me your thoughts about this:

should we include libraries: bz2 and lzma?
should we enable the built of some extra python modules: _bz2.cpython-38.so and _lzma.cpython-38.so (depends on previous steps)?
should we add a pandas recipe (depends on previous steps)?
should we introduce mplfinance recipe (again...depends on previous steps)?

I think that the first three points are worth it...the last one probably too (it doesn't seem hard to maintain).

So depending on the supplied recipes, a different test app will be ran. The supported test apps are: - kivy - flask - no-gui

for our CI providers and `rebuild_updated_recipes.py` because we recently removed the old test app that we made use of.

Remove sentence regarding python2 compatibility... because python2 it's almost at the end of his life

So we can get an apk via gh-actions Notes: - this way the reviewers can install the flask apk without making the build - these changes will be reverted in the next commit...since we want a kivy app as our default)

This reverts commit 0ed4d70.

in case that we detect that p4a will build an `service_only` app. Note: if we don't do this we wil get errors once we try to create our apk with the target distribution

and: - remove Python 2 test apps because: + we already test Python 2 with travis + Python 2 it's almost at the end of his life - change gh-actions job title (because it looks better)

Because it looks better and is more readable.

Because reducing filename to `setup.py` will make our cli arguments shorter and source code cleaner

So our matrix gh-actions builds will not be cancelled if some arch fails which is very useful to fix specific arch issues. See also: kivy#2073

Fix our `CI` travis tests by explicitly omit the numpy build for MacOsX. Yeah...not actually a solution for MacOsX...but at least we will have the `green tick mark` for our `CI` tests...but we have a problem with MacOsX and numpy recipe :< See also: kivy#2073

To fix travis CI tests when trying to build `liblzma` recipe

Because it causes an error when running from `CI`

AndreMiras

Even though the PR is too big to my personal taste, this is some pretty impressive work again 👏
Since it's very big we may overlook a lot of things, but I'm OK to take the risk given the improvements it provides.
I wrote some minor comments, but nothing blocking from my point of view.
Thanks for your time and efforts ❤️

AndreMiras · 2020-03-18T10:53:51Z

doc/source/testing_pull_requests.rst

@@ -103,30 +103,31 @@ Using python-for-android commands directly from the pull request files
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

 - Enter inside the directory of the cloned repository in the above
-  step and run p4a command with proper args, eg::
+  step and run p4a command with proper args, eg (to test an modified


an modified -> a modified

AndreMiras · 2020-03-18T10:55:36Z

pythonforandroid/recipes/libbz2/__init__.py

+
+    # there is not an official release yet...
+    # so pinned to last commit at the time of writing
+    version = "1.0.8"


that doesn't look like a pinned commit to me 🤔

AndreMiras · 2020-03-18T11:02:43Z

pythonforandroid/recipes/mplfinance/__init__.py

@@ -0,0 +1,18 @@
+


Typically this recipe as well as pandas could have been added in another dedicated PR, right?
This two recipe alone are simple enough to review, but in general if should try to reduce huge PR when possible to reviewers don't get scared/discouraged by the size of it or lose focus during the review. Also if large PR receive a lot of comments then the contributor might as well get discouraged or simply side tracked and drop it.
By the way line one is empty 😄

AndreMiras · 2020-03-18T11:06:55Z

pythonforandroid/recipes/mplfinance/__init__.py

+    version = 'cde5008'
+    url = 'https://github.com/matplotlib/mplfinance/archive/{version}.zip'


Jugging from PyPI there're some alpha releases we could use

Suggested change

version = 'cde5008'

url = 'https://github.com/matplotlib/mplfinance/archive/{version}.zip'

version = '0.12.3a3'

url = 'https://pypi.python.org/packages/source/m/mplfinance/mplfinance-{version}.tar.gz'

AndreMiras · 2020-03-18T11:08:44Z

testapps/on_device_unit_tests/README.rst

-only the requirements you ask for (so if you build with requirements
-other than those specified, the tests may fail). It also has no gui
-yet, the results must be checked via logcat.
+This test app can be build via `setup.py` or via buildozer. In both


can be build -> can be built

AndreMiras · 2020-03-18T11:10:09Z

testapps/on_device_unit_tests/setup.py

+This is the `setup.py` file for the `on device unit test app`.
+
+In this module we can control how will be built our test app. Depending on
+our requirements we can build an kivy, flask or a non-gui app. We default to an


an kivy -> a kivy

AndreMiras · 2020-03-18T11:10:50Z

testapps/on_device_unit_tests/setup.py

+
+In this module we can control how will be built our test app. Depending on
+our requirements we can build an kivy, flask or a non-gui app. We default to an
+kivy app, since the python-for-android project its a sister project of kivy.


its a sister -> is a sister

inclement · 2020-03-30T15:07:24Z

Since I'm a little late, what's the status of this, does anything still need comments?

opacam · 2020-03-31T19:02:45Z

Actually we can close this because this was only a draft and, the important stuff, we have it already merged in separate PRs, anyhow...there maybe some interesting tests for the on_device_unit_tests and one recipe for mplfinance, but not to be done here...so closing this and...
¡¡thanks to be here guys!!
😄

opacam added 30 commits March 14, 2020 17:52

📦 Refactor (move) PythonTestMixIn into tests.mixin

e5cd6f4

📦 Unify most of the test apps into one app

52162ef

So depending on the supplied recipes, a different test app will be ran. The supported test apps are: - kivy - flask - no-gui

🚀 Make test app on_device_unit_tests the default...

1ce7d8c

for our CI providers and `rebuild_updated_recipes.py` because we recently removed the old test app that we made use of.

📝 Update docs

1ac5309

🚀 Enhance gh-actions with a matrix for our testapps

f92376c

📝 Fix typo errors and...

6989cb2

Remove sentence regarding python2 compatibility... because python2 it's almost at the end of his life

✅ Make a flask testapp...

4dd643a

So we can get an apk via gh-actions Notes: - this way the reviewers can install the flask apk without making the build - these changes will be reverted in the next commit...since we want a kivy app as our default)

✅ Revert "Make a flask testapp..."

ba86c92

This reverts commit 0ed4d70.

🚀 Remove orientation kwarg...

eb8427e

in case that we detect that p4a will build an `service_only` app. Note: if we don't do this we wil get errors once we try to create our apk with the target distribution

🚀 Build test app for all archs

ea402c1

and: - remove Python 2 test apps because: + we already test Python 2 with travis + Python 2 it's almost at the end of his life - change gh-actions job title (because it looks better)

🚀 Rename test app

d108dd1

Because it looks better and is more readable.

📝 Fix a syntactical error at docstring

26c95f2

🚀 Rename setup_test_app.py to setup.py

b54d8e4

Because reducing filename to `setup.py` will make our cli arguments shorter and source code cleaner

🚀 Disable gh-actions fail-fast

cbebd95

So our matrix gh-actions builds will not be cancelled if some arch fails which is very useful to fix specific arch issues. See also: kivy#2073

✨ Add libbz2 recipe (libbz2.so)

e9c3e0a

✅ Add tests for libbz2 recipe

d404e4b

✨ Add liblzma recipe (liblzma.so)

ee24e23

✅ Add tests for liblzma recipe

184c6ef

✨ Add bz2 and lzma support to Python3

5686941

✨ Add pandas recipe

a0c1a92

✅ Add tests for pandas recipe

5da75de

✨ Add mplfinance recipe

1a4deb7

🚀 Add KiwisolverTestCase to on_device_unit_tests_app

9228336

🚀 Add PandasTestCase to on_device_unit_tests_app

51a02c0

🚀 Add MplfinanceTestCase to on_device_unit_tests_app

6e4972a

💚 Add new dependency (autopoint)

33a8a9a

To fix travis CI tests when trying to build `liblzma` recipe

🐛 Remove pandas dependencies from setup.py

9d111d9

Because it causes an error when running from `CI`

🐛 Create install dir for liblzma

fc0c6a6

🚧 Pass the apk's requirements from the CI files

47bbd9f

opacam added the WIP label Mar 17, 2020

opacam requested review from AndreMiras and inclement March 17, 2020 21:54

AndreMiras approved these changes Mar 18, 2020

View reviewed changes

This was referenced Mar 24, 2020

✨ Compression libraries - episode I: libbz2 #2095

Merged

✨ Compression libraries - episode II: liblzma #2096

Merged

✨ Compression libraries - episode III: add support for libbz2 & liblzma to python3 #2097

Merged

✨ Add pandas recipe #2100

Merged

opacam closed this Mar 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Playing with `on_device_unit_test_app` #2046 - Episode II #2088

Playing with `on_device_unit_test_app` #2046 - Episode II #2088

opacam commented Mar 17, 2020

AndreMiras left a comment

AndreMiras Mar 18, 2020

AndreMiras Mar 18, 2020

AndreMiras Mar 18, 2020

AndreMiras Mar 18, 2020

AndreMiras Mar 18, 2020

AndreMiras Mar 18, 2020

AndreMiras Mar 18, 2020

inclement commented Mar 30, 2020

opacam commented Mar 31, 2020

		version = 'cde5008'
		url = 'https://github.com/matplotlib/mplfinance/archive/{version}.zip'

Playing with on_device_unit_test_app #2046 - Episode II #2088

Playing with on_device_unit_test_app #2046 - Episode II #2088

Conversation

opacam commented Mar 17, 2020

AndreMiras left a comment

Choose a reason for hiding this comment

AndreMiras Mar 18, 2020

Choose a reason for hiding this comment

AndreMiras Mar 18, 2020

Choose a reason for hiding this comment

AndreMiras Mar 18, 2020

Choose a reason for hiding this comment

AndreMiras Mar 18, 2020

Choose a reason for hiding this comment

AndreMiras Mar 18, 2020

Choose a reason for hiding this comment

AndreMiras Mar 18, 2020

Choose a reason for hiding this comment

AndreMiras Mar 18, 2020

Choose a reason for hiding this comment

inclement commented Mar 30, 2020

opacam commented Mar 31, 2020

Playing with `on_device_unit_test_app` #2046 - Episode II #2088

Playing with `on_device_unit_test_app` #2046 - Episode II #2088