Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pathlib to get path to site-packages instead of importlib.resources #707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

occasional-contributor
Copy link

The existing method fails with ValueError when using pyjnius in a slash test.

The existing method fails with `ValueError` when using `pyjnius` in a [`slash`](https://github.com/getslash/slash) test.
@cmacdonald
Copy link
Contributor

I'm the originator of this code, which follows the recommendations in the documentation linked in the code.

Can you say more about the raised ValueError? Why is importlib.resources not the best way?

@occasional-contributor
Copy link
Author

I need to create a PoC to show where/how it breaks.

@cmacdonald
Copy link
Contributor

please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants