Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iterators py2 #507

Merged
merged 4 commits into from
Apr 11, 2020
Merged

Fix iterators py2 #507

merged 4 commits into from
Apr 11, 2020

Conversation

tshirtman
Copy link
Member

No description provided.

@tshirtman
cleanup
8a32989
@tshirtman
fix issue with iterators in python2
8196cd4 
not a *great* solution, but shouldn't impact code that uses the java
api, and allow using the pythonic api.
@tshirtman tshirtman mentioned this pull request Apr 11, 2020
Merged
@tshirtman
Copy link
Member Author

arf, of course i broke something in my cleanup :)

cmacdonald
cmacdonald approved these changes Apr 11, 2020
View reviewed changes
Copy link
Contributor

@cmacdonald cmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much more elegant. looks good to me. And passes all checks.
+1

@tshirtman tshirtman merged commit 8461364 into master Apr 11, 2020
@tshirtman tshirtman deleted the fix_iterators_py2 branch April 11, 2020 20:17
@cmacdonald
Copy link
Contributor

Thanks for sorting this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacdonald cmacdonald cmacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshirtman @cmacdonald