Python workaround for wrong constructor selection cf #474 #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmacdonald
changed the title
|
In daylight, I prefer |
tshirtman
previously approved these changes
Feb 9, 2020
There was a problem hiding this comment.
That looks good, i only wonder if get or pop will make a difference in the future, in case we want more kwargs there, but it's really not a biggy, i also agree that signature is better than param_types, if you want to do the change.
Nice job about the test, thanks.
tshirtman
approved these changes
Feb 9, 2020
|
Thanks! |
tshirtman
added a commit
that referenced
this pull request
May 3, 2020
Full Changelog: 1.2.1...1.3.0 Implemented enhancements: - (#483) allow passing a `signature` argument to constructors, to force selection of the desired one - (#497) support for more "dunder" methods/protocols on compatible interfaces than just `__len__`, and allow users to provide their own. - (#500) allow ignoring private methods and fields in autoclass (both default to False) - (#503) auto detect java_home on OSX, using `/usr/libexec/java_home` (if JAVA_HOME is not declared) - (#514) writing to static fields (and fix reading from them) - (#517) make signature exceptions more useful - (#502) provide a stacktrace for where JVM was started. - (#523) expose the class's class attribute - (#524) fix handling of Java chars > 256 in Python3 - (#519) Always show the exception name Fixed bugs: - (#481) wrong use of strip on JRE path - (#465) correct reflection to avoid missing any methods from parent classes or interfaces - (#508) don't had error details with a custom exception when java class is not found - (#510) add missing references to .pxi files in setup.py, speeding up recompilation - (#518) ensure autoclass prefers methods over properties - (#520) improved discovery of libjvm.so + provide a workaround if it doesn't work Documentation: - (#478) document automatic Thread detach feature - (#512) document the requirement to keep reference to object/functions passed to java, for as long as it might use them - (#521) fix inheritance in example Many thanks to the contributors that stepped up to help this release, it wouldn't have been possible without them. Craig Macdonald, Gabriel Pettier, Jim, André Miras, Young Ryul Bae, yyang, Pascal Chambon, Kevin Ollivier, Guillaume Gay, Christian M. Salamut, collaborated for this release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see this as a possible workaround for #474. Constructors can take optional kwargs that provide the specification for the desired constructor. Unit tests included.