-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OSX setup #364
Fix OSX setup #364
Conversation
@hadim Could you also add a travis build for OSX with java 8 and java 9+? You can check the matrix at plyer |
Sorry but I don't have an osx machine so it's complicated for me to test. Only the osx/Java 8 builds are failing: https://travis-ci.org/kivy/pyjnius/jobs/459157377 Could you take care of it from here? |
To test it quickly you can temporarily remove linux from the matrix and various python versions e.g. just keep osx 2.7 and 3.7 for java 8 and java 9. What I think is happening is this: #304 (comment) i.e. a missing |
I am already working on the conda forge feedstock. Could you take care of this one? |
The |
@KeyWeeUsr I have disabled Java 8/OSX build on Travis. Can you merge and I'll try to submit a new PR later this week if you cannot do it? |
I took a look at it and I believe https://github.com/kivy/pyjnius/pull/364/files#diff-2eeaed663bd0d25b7e608891384b7298R124 is the mistake in here if you use Edit: Java 8 definitely has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The builds are all green! Thank you for the fix :-)
Yes finally. Hope you'll release a new version soon! |
Ping @KeyWeeUsr.
In the OSX if statement
JRE_HOME
is not defined.