Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSX setup #364

Merged
merged 11 commits into from
Nov 24, 2018
Merged

Fix OSX setup #364

merged 11 commits into from
Nov 24, 2018

Conversation

hadim
Copy link
Contributor

@hadim hadim commented Nov 24, 2018

Ping @KeyWeeUsr.

In the OSX if statement JRE_HOME is not defined.

@KeyWeeUsr
Copy link
Contributor

@hadim Could you also add a travis build for OSX with java 8 and java 9+? You can check the matrix at plyer .travis.yml.

@KeyWeeUsr KeyWeeUsr self-assigned this Nov 24, 2018
@hadim
Copy link
Contributor Author

hadim commented Nov 24, 2018

Sorry but I don't have an osx machine so it's complicated for me to test.

Only the osx/Java 8 builds are failing: https://travis-ci.org/kivy/pyjnius/jobs/459157377

Could you take care of it from here?

@KeyWeeUsr
Copy link
Contributor

To test it quickly you can temporarily remove linux from the matrix and various python versions e.g. just keep osx 2.7 and 3.7 for java 8 and java 9. What I think is happening is this: #304 (comment) i.e. a missing jre folder for Java 8. If you do ls -lah for particular folders in the CI job, you'll get there :)

@hadim
Copy link
Contributor Author

hadim commented Nov 24, 2018

I am already working on the conda forge feedstock. Could you take care of this one?

@hadim
Copy link
Contributor Author

hadim commented Nov 24, 2018

The Allow edits from maintainers. box is checked.

@hadim
Copy link
Contributor Author

hadim commented Nov 24, 2018

@KeyWeeUsr I have disabled Java 8/OSX build on Travis. Can you merge and I'll try to submit a new PR later this week if you cannot do it?

@KeyWeeUsr
Copy link
Contributor

KeyWeeUsr commented Nov 24, 2018

I took a look at it and I believe https://github.com/kivy/pyjnius/pull/364/files#diff-2eeaed663bd0d25b7e608891384b7298R124 is the mistake in here if you use conda. I have no experience with conda, so you'll have more luck with it, since the original fix is yours. You might try to install Java 8 the ordinary way, without conda.

Edit: Java 8 definitely has the jre folder and it's missing, therefore the check for path appears to be wrong.

Copy link
Contributor

@KeyWeeUsr KeyWeeUsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builds are all green! Thank you for the fix :-)

@KeyWeeUsr KeyWeeUsr merged commit 8aa9178 into kivy:master Nov 24, 2018
@hadim hadim deleted the fix-osx branch November 24, 2018 20:54
@hadim
Copy link
Contributor Author

hadim commented Nov 24, 2018

Yes finally. Hope you'll release a new version soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants