Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup fixes for python 3 #177

Merged
merged 2 commits into from
Nov 4, 2015
Merged

Followup fixes for python 3 #177

merged 2 commits into from
Nov 4, 2015

Conversation

benson-basis
Copy link
Contributor

  • stop using future except in tests, use six instead
  • fix py2 vs py3 issues with decode in setup.py, might fix windows. Might fix android.

@benson-basis
Copy link
Contributor Author

Android succeeds at create with these changes.

@dessant
Copy link
Contributor

dessant commented Nov 4, 2015

We could avoid using six in setup.py, you could declare PY3 = sys.version_info >= (3,0,0) somewhere at the start and use that boolean for further checks.

@dessant
Copy link
Contributor

dessant commented Nov 4, 2015

It does fail for windows even with pyhon 2, but i think that is not caused by your code, I've tried to install an older commit and it is just as broken. I'll post some error logs regarding that, but the priority is android, linux and osx for now.

@@ -9,7 +9,7 @@ before_install:
- sudo apt-get install python-pip openjdk-7-jdk

install:
- pip install --upgrade cython future
- pip install --upgrade cython future six
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future not needed anymore?

@akshayaurora
Copy link
Member

@benson-basis thanks for this, could we remove future dependency all together? instead of using both future and six?

@benson-basis
Copy link
Contributor Author

It's time-consuming to get all the 'future' out of the tests. I'll do it,
but I wanted to unblock things first.

On Wed, Nov 4, 2015 at 8:39 AM, Akshay Arora notifications@github.com
wrote:

@benson-basis https://github.com/benson-basis thanks for this, could we
remove future dependency all together? instead of using both future and six?


Reply to this email directly or view it on GitHub
#177 (comment).

@benson-basis
Copy link
Contributor Author

@dessant I think this should solve everything mentioned except for adroid and getting rid of future from the tests. As noted elsewhere, I'm a bit stumped on the android side.

@inclement inclement merged commit 10cbae9 into kivy:master Nov 4, 2015
@inclement
Copy link
Member

Thanks for the fixes. I've manually removed the apk stuff in the Makefile though as it's out of place (especially with the hardcoded machine-specific paths) - it would be better to add a test of some kind, or perhaps a pyjnius-specific test in p4a itself.

@benson-basis
Copy link
Contributor Author

Thanks.

On Wed, Nov 4, 2015 at 5:47 PM, Alexander Taylor notifications@github.com
wrote:

Thanks for the fixes. I've manually removed the apk stuff in the Makefile
though as it's out of place (especially with the hardcoded machine-specific
paths) - it would be better to add a test of some kind, or perhaps a
pyjnius-specific test in p4a itself.


Reply to this email directly or view it on GitHub
#177 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants