-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followup fixes for python 3 #177
Conversation
Android succeeds at create with these changes. |
We could avoid using six in setup.py, you could declare |
It does fail for windows even with pyhon 2, but i think that is not caused by your code, I've tried to install an older commit and it is just as broken. I'll post some error logs regarding that, but the priority is android, linux and osx for now. |
@@ -9,7 +9,7 @@ before_install: | |||
- sudo apt-get install python-pip openjdk-7-jdk | |||
|
|||
install: | |||
- pip install --upgrade cython future | |||
- pip install --upgrade cython future six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future not needed anymore?
@benson-basis thanks for this, could we remove future dependency all together? instead of using both future and six? |
It's time-consuming to get all the 'future' out of the tests. I'll do it, On Wed, Nov 4, 2015 at 8:39 AM, Akshay Arora notifications@github.com
|
@dessant I think this should solve everything mentioned except for adroid and getting rid of future from the tests. As noted elsewhere, I'm a bit stumped on the android side. |
Thanks for the fixes. I've manually removed the apk stuff in the Makefile though as it's out of place (especially with the hardcoded machine-specific paths) - it would be better to add a test of some kind, or perhaps a pyjnius-specific test in p4a itself. |
Thanks. On Wed, Nov 4, 2015 at 5:47 PM, Alexander Taylor notifications@github.com
|
future
except in tests, usesix
insteaddecode
insetup.py
, might fix windows. Might fix android.