Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --no-deps and --platform during install of recipe python deps #801

Merged
merged 2 commits into from
May 15, 2023

Conversation

misl6
Copy link
Member

@misl6 misl6 commented May 13, 2023

Why only for pip installations made via install_python_deps and not for everything (e.g toolchain pip install) ?

Basically just for not breaking things for users now, since we likely need to write a guide for parsing dependencies, but we're in a rush for releasing 2.2.0rc1 (which need additional python_deps compared to 2.1.0)

Why --platform any ?

Well, packages like charset-normalizer (which is a dependency of requests) ship to PyPi both platform-specific wheels (like charset_normalizer-3.1.0-cp311-cp311-macosx_10_9_universal2.whl) and non-platform specific wheels (charset_normalizer-3.1.0-py3-none-any.whl).

In kivy-ios we need to ask pip to install a non-platform-specific version (otherwise it will install the macosx version, which is not compatible with iOS)

Wow. --platform seems nice feature, but why --no-deps?

Well, unfortunately, --platform does not work alone.

ERROR: When restricting platform and interpreter constraints using --python-version, --platform, --abi, or --implementation, either --no-deps must be set, or --only-binary=:all: must be set and --no-binary must not be set (or must be set to :none:).

AndreMiras
AndreMiras previously approved these changes May 13, 2023
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but build is failing, I haven't investigated why

@misl6 misl6 force-pushed the feat/no-deps-on-recipe-python-deps branch from f4f80c3 to 63a1259 Compare May 13, 2023 19:06
@misl6
Copy link
Member Author

misl6 commented May 13, 2023

LGTM, but build is failing, I haven't investigated why

I gone too fast 😀, and missed an important chunk of code. Updated it.

@misl6 misl6 merged commit 8d211b5 into kivy:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants