Fixes Pillow build on Xcode 12.2 #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Can't test myself but this seems pretty clear. |
|
Checking out this branch and running "python toolchain.py build kivy python3 pillow" gives me the below. Using XCode 12.3 on MacOS 11.1. I know these are not the exact versions you are using, but the are the current automatics, so I think it's pointless to try with anything less... |
|
The CI is building fine but it's on MacOS 10.15.7 and XCode 12.2. (https://github.com/actions/virtual-environments/blob/macOS-10.15/20201212.1/images/macos/macos-10.15-Readme.md) Googling around I found out something interesting related to Edit: I will add a CI check with macos-11, so We can be sure that it also builds fine on macOS 11.0 Big Sur |
|
I'm getting linking issues here? Downgrading to 12.2 just to check (OSX had updated me to 12.3 of course...). EDIT: Just noticed @misl6 uses 12.3 successfully... reinstalling that, and I'll post the errors. I'm on OSX 10.15.7 BTW, not 11. EDIT2: Another thing, I thought it could be because of Python 3.9, so I downgraded to 3.8, but I see from your CI specs Mirko that you're using 3.9, so that's also a dead end - I'll go back to 3.9 myself. Posting logs ASAP. EDIT3: Logs: |
|
@Cheaterman |
|
Hi @misl6 :-) kivy-ios master freshly pulled, venv, install cython inside venv, Creating issue now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #556 .
That one was broken since a age 😄 , but with XCode < 12.x, also if the needed flags were missing, considering that
-arch arm64was passed, Xcode considered that as an iOS build. (A bug sometimes it's a feature)Now, with XCode > 12.x, arm64 is something that exists in MacOS (Apple Silicon M1), so without the needed flags got treated as a MacOS build.