Handles unknown command/target error gracefully, closes #812 #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `buildozer unknown_command` should show a meaningful error and exit. Fixes regression introduced in 4936d31 and adds unit tests. Also updates other tests `assert` keyword rather than `self.assert*` in order to keep style consistent. Last, minor `Dockerfile` documentation update as per recent @tshirtman feedback.
inclement
approved these changes
Mar 12, 2019
AndreMiras
deleted the
feature/ticket812_fix_AttributeError_translate_target
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
buildozer unknown_commandshould show a meaningful error and exit. Fixes regression introduced in 4936d31 and adds unit tests.Also updates other tests
assertkeyword rather thanself.assert*in order to keep style consistent.Last, minor
Dockerfiledocumentation update as per recent @tshirtman feedback.