Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci_mode to toggle download progress #833

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

mkg20001
Copy link
Contributor

Ref #823

@AndreMiras
Copy link
Member

Great work! Same comment as kivy/python-for-android#1727 (comment) could you review/address? 🙏

@mkg20001
Copy link
Contributor Author

Noticed that the unzip command still spams

screenshot

Would anybody mind looking into that?

@AndreMiras AndreMiras merged commit 46bcf95 into kivy:master Feb 25, 2019
@AndreMiras
Copy link
Member

Merged thanks!
Regarding the extraction command I think it comes from here https://github.com/kivy/python-for-android/blob/6660b9e/pythonforandroid/recipe.py#L405 but I haven't verified yet.
Basically tar -tf the -t flag is the verbose part, see man page:

List the contents of an archive. Arguments are optional. When given, they specify the names of the members to list.

But let's keep it for another story so I'm merging your PR which already is an improvement. Thanks for making a commit amend/squash by the way, I also like clean commit log 😄

@mkg20001
Copy link
Contributor Author

Could you merge kivy/python-for-android#1727 as well, please?

@AndreMiras
Copy link
Member

Yes but for kivy/python-for-android#1727 to make sense we need the .travis.yml update as well, do you mind making the change to the PR? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants