Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dist dir if running distribute.sh #81

Merged
merged 1 commit into from
Apr 8, 2014
Merged

Conversation

inclement
Copy link
Member

This pr makes buildozer delete the existing p4a distribution if it is going to run distribute.sh

This is important because p4a raises an error message/question if the distribution already exists, but unless log_level=2 this message is not displayed by buildozer, so it looks like buildozer is hanging.

I don't know if this is the best way to solve the problem, but something needs to be done to fix the bug, and I couldn't think of anything better.

@LilyFoote
Copy link
Contributor

Why is the message only shown at log_level = 2?

@inclement
Copy link
Member Author

I'm not sure about the details, but ultimately I think because buildozer suppresses the normal output of python-for-android if log_level < 2.

You can reproduce it by setting $ANDROID_P4A_DIR to use a local python-for-android, and building an app (this will work fine), then deleting the .buildozer and building again. Buildozer will symlink the system p4a and run distribute.sh because it doesn't know if the existing dist satisfies its dependencies, and python-for-android will print its 'distribution already exists' message. If log_level < 2, this message is not displayed by buildozer, which just hangs waiting for input.

@alanjds
Copy link
Contributor

alanjds commented Feb 10, 2014

@inclement What about changing p4a to have an option that force it to do not ask questions? like --yes or --no ?

P4a build is one of the slowest steps of buildozer IMHO, so I would like to skip it if not needed.

@inclement
Copy link
Member Author

That's a good idea in general.

The reason buildozer does this in general is because it doesn't know whether the existing dist meets its requirements. Maybe it would be possible to check them...I'm not sure how they're stored, but it would be a much neater solution.

I will look at it...

@alanjds
Copy link
Contributor

alanjds commented Feb 10, 2014

It would be the heavens, yes :) . But for now, I had already disabled the P4A build on buildozer at my local p4a build cloud...

tito added a commit that referenced this pull request Apr 8, 2014
Delete dist dir if running distribute.sh
@tito tito merged commit b8902d1 into kivy:master Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants