Show envs when run2 #802
Show envs when run2 #802
Conversation
|
I think that makes sense, thank you @mahomahomaho |
|
Thanks for taking another look. I just realised that yes that hardcoded number things was already in our code base 😅 I'll unit test some of it, refactor and probably merge your PR after further review |
|
I've created #831 to help with testing the logger before we can merge yours |
| @@ -282,6 +296,7 @@ def cmd(self, command, **kwargs): | |||
| else: | |||
| self.debug('Run {0!r} ...'.format(command.split()[0])) | |||
| self.debug('Cwd {}'.format(kwargs.get('cwd'))) | |||
| self.log_env(self.DEBUG, kwargs["env"]) | |||
There was a problem hiding this comment.
I think that like should be removed.
I'm seeing it only now after using buildozer master for a while.
For instance during the auto accept license process, this log_env seems to be printing every time. We want it only after crashes, not for every command call
There was a problem hiding this comment.
I've created a PR to remove that line #843
When some command fails, it's good to know what envs was set, to be able to reproduce error.
Also few formatting changes forced by flake8