Introduces CI and tox testing, fixes #679 #794
Conversation
AndreMiras
commented
Jan 16, 2019
AndreMiras
commented
- run setup.py on both Python2 and Python3
- runs simple test case for both Python2 and Python3
- checks the PEP8 style
- updates README.md adds Travis badge
- run setup.py on both Python2 and Python3 - runs simple test case for both Python2 and Python3 - checks the PEP8 style - updates README.md adds Travis badge
|
Build is green https://travis-ci.com/kivy/buildozer/builds/97610519 ✔️ |
| ignore = | ||
| E121, E122, E123, E125, E126, E127, E128, E129, E131, E226, E231, E241, | ||
| E262, E265, E301, E302, E303, E305, E402, E501, E502, E722, E731, E741, | ||
| F401, F821, F841, W391, W504, W605 |
There was a problem hiding this comment.
We will fix the most important errors little by little in subsequent pull requests
| Basic test making sure the Buildozer object can be instanciated. | ||
| """ | ||
| buildozer = Buildozer() | ||
| self.assertEqual(buildozer.specfilename, 'buildozer.spec') |
There was a problem hiding this comment.
This test will not catch #791 yet because buildozer.spec file doesn't exist, see https://github.com/kivy/buildozer/blob/46cc8f7/buildozer/__init__.py#L121
But I'll write a dedicated test for this case once this gets merged.
|
|
||
| python: | ||
| - "2.7" | ||
| - "3.6" |
There was a problem hiding this comment.
I'll purposely go for 3.6 rather because 3.7 still feels too cutting edge to me and 3.6 more mainstream while not legacy
There was a problem hiding this comment.
Not sure I agree with that. 3.7 is the current python release, and it's what gets installed by default if I ask for python3 in many places (e.g. my main use case: conda create -n new_environment python=3 ...
There was a problem hiding this comment.
Not on Ubuntu 18.04 LTS. Plus it's failing a lot of recipes, e.g. gevent, and when you check on upstream they say, we don't support 3.7 yet. But yes that's debatable.
In any case this PR is not about dropping some support, but more like adding testing where we had none.
Edit: thanks for the feedback by the way, very much appreciated!
