Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle buildozer.spec with unicode chars #789

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Handle buildozer.spec with unicode chars #789

merged 1 commit into from
Jan 14, 2019

Conversation

guysoft
Copy link
Contributor

@guysoft guysoft commented Jan 13, 2019

Other wise you get a UnicodeEncodeError in python3.

@guysoft
Copy link
Contributor Author

guysoft commented Jan 13, 2019

The reason this is needed, because of the line:
https://github.com/kivy/buildozer/blob/master/buildozer/default.spec#L65

author = © Copyright Info

@AndreMiras AndreMiras mentioned this pull request Jan 13, 2019
Closed
@AndreMiras
Copy link
Member

Thanks for the fix, that may fix #782
Funny to see it pops only now. Also I'm not sure why I can't reproduce it myself 🤔

@homdx
Copy link

homdx commented Jan 14, 2019

@guysoft , thank you!

Log:
#782 (comment)

@AndreMiras AndreMiras merged commit c66af5d into kivy:master Jan 14, 2019
@AndreMiras AndreMiras mentioned this pull request Jan 16, 2019
Closed
@hackalog
Copy link
Contributor

hackalog commented Jan 21, 2019 •
edited
Loading

Note for posterity. This caused a python2 regression. Fixed in #791. Unit test added in #799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guysoft @AndreMiras @homdx @hackalog