Add 404 status code handling on kivy download #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Kivy Downloads section is down due to kivy/kivy#5211 the OSX build target has been failing if you are missing the Kivy dependency. (It's been a couple days since it's been taken down, and troubleshooting this is pretty annoying for any devs who clean their build environment.)
This PR will handle the case when the Kivy dependency cannot be downloaded. It will cover the case where the server returns 404, (such is the case now). It will also cover when a user specifies an incorrect kivy version in osx.kivy_version.