Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly hack to fix wrong data being used for target Android API in new … #286

Closed
wants to merge 1 commit into from

Conversation

mixedCase
Copy link

…toolchain

The old toolchain passes only the SDK version, which is not the same as the target API. This attempts to correct the problem, but should probably be correctly dealt with once the new toolchain becomes the default one.

@kived
Copy link
Contributor

kived commented May 7, 2016

The proper fix would be in the android target. There's no need for an ugly hack, the android target does it wrong as well. It passes the sdk value as api and the minsdk value (which doesn't exist) as minapi. The issue is that the old toolchain uses --sdk and --minsdk to set the API levels.

@mixedCase
Copy link
Author

Is there any issue open about this? If this is going to be properly fixed soon then I guess this PR is better off closed.

@kived
Copy link
Contributor

kived commented May 7, 2016

No, I don't think there is any issue open. The confusion stems from the <uses-sdk /> tag in AndroidManifest.xml, which specifies the API levels for your application.

So in p4a old-toolchain, --sdk specifies the target API for your application, and --minsdk sets the minimum API. But in buildozer.spec, android.api and android.minapi set those values, while android.sdk is the actual SDK version and android.minsdk doesn't exist.

@kived
Copy link
Contributor

kived commented May 8, 2016

Fixed in #334, but thanks for pointing out the issue. :)

@kived kived closed this May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants