Fixed logic to compare with “non installed” with “minor version upped" #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x: 20.0.1) method bulldozer.targets.android.TargetAndroid._install_android_packages() If build-tools is not installed, then variable "v_build_tools" is string = '0'. If latest version contains minor version code ~ example 19.0.3 ~, then variable "ver" is list = [19, 0, 3]. In that case, build-tools is not enable to install, because expression([19, 0, 3] > '0') returns False.
|
This might resolve issue #146. |
attakei
force-pushed
the
patches/resolve_compare_versions
branch
from
1948550
to
c6b4235
Compare
|
Just tested this and it fixes the build issue nicely, can we see this merged ? |
tito
added a commit
that referenced
this pull request
Nov 13, 2014
Fixed logic to compare with “non installed” with “minor version upped"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In verifying #155, I have failed to install build-tool another reasons.
So, I try to fix it. (These and #155 are independent of each other.)
Issue 1: When packaging begin from a fresh clone of buildozer, it is always failed to check latest version of build-tool.
Current logic:
v_build_tools = '0'
ver = [1, 2, 3]
'0' > [1, 2, 3]
--> False, do not run install build-tool.
Fixed:
v_build_tools = [0]
ver = [1, 2, 3]
[0] > [1, 2, 3]
--> True, do not run install build-tool.
Issue 2: wrong args for _android_update_sdk()
Method expects string as arg, but passed with list.
Fix to pass package name based from version list, for example ver=[1,2,3'] --> arg='build-tool-1.2.3'.
attakei