Removes broken and unneeded checks, now we can support additional permission syntaxes. #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and un-needed checks.
AndreMiras
approved these changes
Jan 22, 2023
misl6
changed the title
Changed to "Removes broken and unneeded checks, now we can support additional permission syntaxes." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related python-for-android PR: kivy/python-for-android#2725
android.permissionsnow accepts all the syntaxes supported bypython-for-android.Removed broken and un-needed checks related to android permissions:
_get_available_permissionsis looking for a file that does not exist anymore at the provided location, so everything is already considered "ok". Basically the check is already skipped.In general, IMHO is better to leave the error-handling for Android-specific things to the Android toolchain (or to
python-for-androidif it makes sense), as these things change fast .