Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow displaying only the logcat of our app. #1272

Merged
merged 2 commits into from
Feb 21, 2021
Merged

Conversation

tshirtman
Copy link
Member

@tshirtman tshirtman commented Jan 4, 2021

Todo

  • test with a service
  • consider making default
  • test for robustness

To discuss

  • should it exit automatically like it does currently? what if user reruns manually?
  • consider the cost of additional complexity vs usage simplification for users

Todo
[ ] test with a service
[ ] consider making default
[ ] test for robustness

To discuss
[ ] should it exit automatically like it does currently? what if user reruns manually?
[ ] consider the cost of additional complexity vs usage simplification for users
AndreMiras
AndreMiras previously approved these changes Jan 7, 2021
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not, except for your last point code complexity vs benefit.
I can already see some benefit as inexperienced developers often find it hard to look the adb logs so that could potentially help.
But this feature could be redundant with the built-in adb filters, while the implementation is totally different, the result might look the same.
Still nothing against that PR

@tshirtman
Copy link
Member Author

I didn't try, but i think this should have one advantage over filtering, as it should also display lower level errors, like stacktraces, that can be hidden when using the "Python" prefix as a filter, also, in the hopefuly plausible of the users having multiple python applications installed, it should filter only the one they are trying to debug.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tshirtman tshirtman merged commit b24b77b into master Feb 21, 2021
@tshirtman tshirtman deleted the logcat_filter_pid_exit branch February 21, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants