Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for controlling p4a distutils support, fixes #1224 #1225

Merged
merged 3 commits into from
Sep 13, 2020
Merged

Add option for controlling p4a distutils support, fixes #1224 #1225

merged 3 commits into from
Sep 13, 2020

Conversation

rambo
Copy link
Contributor

@rambo rambo commented Sep 11, 2020

as per #1224

  1. We need to pass the option explicitly to keep old default behaviour in the future
  2. user should be able to control whether distutils support is enabled or not.

AndreMiras
AndreMiras approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request 🙏

AndreMiras
AndreMiras requested changes Sep 11, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I overlooked one thing. Do you mind fixing the broken test tests/targets/test_android.py

@rambo
Copy link
Contributor Author

rambo commented Sep 11, 2020

Yeah noticed that too from the CI report, I'm having weird problems with tox in the Ubuntu VM I'm doing this on so forgot to run tests (and in python-for-android -side just running py.test also throws up in weird ways so I didn't even remember to try that here)

AndreMiras
AndreMiras approved these changes Sep 13, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AndreMiras AndreMiras merged commit 7b35b3d into kivy:master Sep 13, 2020
@rambo rambo deleted the issue-1224 branch September 14, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rambo @AndreMiras