-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instalation.rst for Windows 10 #1123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for giving Windows instructions some love!
Could this be slightly reworked to make avoid repeating ourselves? Mainly the apt
section I think should be shared/referencing the one above from Ubuntu
docs/source/installation.rst
Outdated
sudo apt update | ||
sudo apt install -y git zip unzip openjdk-8-jdk python3-pip autoconf libtool pkg-config zlib1g-dev libncurses5-dev libncursesw5-dev libtinfo5 cmake libffi-dev libssl-dev | ||
# Use here the python version you need | ||
sudo apt install -y python3.7-venv | ||
# Create a folder for buildozer | ||
mkdir /mnt/c/buildozer | ||
cd /mnt/c/buildozer | ||
python3.7 -m venv venv-buildozer | ||
source venv/bin/activate | ||
python -m pip install --upgrade pip | ||
python -m pip install --upgrade wheel | ||
python -m pip install --upgrade cython | ||
python -m pip install --upgrade virtualenv | ||
python -m pip install --upgrade buildozer | ||
# Add the following line at the end of your ~/.bashrc file | ||
export PATH=$PATH:~/.local/bin/ | ||
# Restart your WSL terminal to enable the path change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like most of this could reuse what already holds true in the Ubuntu install section above, that way we don't repeat ourselves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I 'm gonna change it
docs/source/installation.rst
Outdated
export PATH=$PATH:~/.local/bin/ | ||
# Restart your WSL terminal to enable the path change | ||
|
||
Now you need to install the Windows version of ADB (Android Debug Bridge): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the version "shipped" by buildozer enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my tests ADB for Windows was needed to detect the USB connected Android device. Maybe Windows Subsystem for Linux does not have direct access to hardware. ADB in Windows detects the USB device and start the daemon. ADB in buildozer (in WSL) connects to the daemon and access the USB device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i did spend some time supporting an user in that case sometime ago, WSL indeed doesn't have USB support, so the only way is to use the adb daemon started in windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably a good idea to add a note so they get the same adb version as the one installed by buildozer, even if it's probably going to happen by default most of the time, as if they do not, every time they will run one adb on any side, this one will kill the daemon and restart it, so it won't work.
Updated Windows 10 installation instructions avoiding duplication
Required changes were made |
@arqeco thanks 👍 |
Instructions for installing Buildozer on Windows 10