fix: CI and Tests #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzploss-k
force-pushed
the
moritz--fix-and-upgrade
branch
from
959b9da to
73c1b6c
Compare
moritzploss-k
force-pushed
the
moritz--fix-and-upgrade
branch
4 times, most recently
from
961289c to
006914c
Compare
moritzploss-k
commented
Jan 12, 2024
Comment on lines
+68
to
+84
| -type context() :: proplists:proplist(). | ||
| -type auth() :: #a{}. | ||
| -type user() :: any(). %% Opaque User Object | ||
| -type client() :: any(). %% Opaque Client Object | ||
| -type resowner() :: any(). %% Opaque Resource Owner Object | ||
| -type rediruri() :: any(). %% Opaque Redirection URI | ||
| -type device_id() :: any(). | ||
| -type token() :: binary(). | ||
| -type response() :: oauth2_response:response(). | ||
| -type lifetime() :: non_neg_integer(). | ||
| -type scope() :: list(binary()) | binary(). | ||
| -type appctx() :: term(). | ||
| -type error() :: access_denied | invalid_client | invalid_grant | | ||
| invalid_request | invalid_authorization | invalid_scope | | ||
| unauthorized_client | unsupported_grant_type | | ||
| unsupported_response_type | server_error | | ||
| temporarily_unavailable | atom(). |
There was a problem hiding this comment.
only added new device_id() type, and increased the indentation for all others
moritzploss-k
force-pushed
the
moritz--fix-and-upgrade
branch
from
006914c to
50655ac
Compare
moritzploss-k
force-pushed
the
moritz--fix-and-upgrade
branch
from
50655ac to
4272752
Compare
k-patrik
approved these changes
Jan 15, 2024
| @@ -218,15 +218,21 @@ to_binary([Binary]) when is_binary(Binary) -> | |||
| to_binary([BinaryHead | Tail]) when is_binary(BinaryHead) -> | |||
| <<BinaryHead/binary, " ", (to_binary(Tail))/binary>>; | |||
| to_binary(List) when is_list(List) -> | |||
| to_binary(list_to_binary(List)); | |||
| erlang:display({list, List}), | |||
RSBRK
reviewed
Jan 16, 2024
Comment on lines
-115
to
-126
| %% @doc Sign the grant context with a private key and produce a JWT. | ||
| %% The grant context is a proplist carrying information about the identity | ||
| %% with which the token is associated, when it expires, etc. | ||
| -callback jwt_sign(grantctx(), appctx()) -> {ok, token()}. | ||
|
|
||
| %% @doc Verifies a JWT, returning the corresponding grant context if | ||
| %% verification succeeds. | ||
| -callback jwt_verify(token()) -> {ok, grantctx()} | {error, badjwt}. | ||
|
|
||
| %% @doc A case-sensitive string or URI that uniquely identifies the issuer. | ||
| -callback jwt_issuer() -> binary(). | ||
|
|
There was a problem hiding this comment.
These call backs were not going to be removed because it's a public repo? Commenting so we don't forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is a public repo. Don't discuss Kivra internals here.
About
Fix broken CI and tests; remove unused callbacks.