-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oauth2: connection of auth code with access token #67
base: master
Are you sure you want to change the base?
Conversation
Thank you for contributing. I have a couple of questions before merging this, and it seems to me that these are two rather independent commits. Would you mind creating two separate pull requests for this? |
hi @dvaergiller, thanks for taking in account my PR! 😄 |
* On access token creation, the relation with the auth code is saved. (addresses kivra#66) Signed-off-by: Leonardo Rossi <leonardo.rossi@studenti.unipr.it>
Thank you. I will close this one for the sake of the new PRs. |
@dvaergiller looks like he already moved one commit to the other PR. and only one commit left here |
My bad. Reopening. |
On this one I would like some more information. Is there any particular use case that is not fulfilled without saving the auth code in the context? Without looking into it that much, I am not 100% sure that there are no security implications to consider here. |
As mentioned in the commit message, I'm trying to handle the case of access token revocation by the user. |
Hi @dvaergiller , any news about my PR? :) |
Hi. Sorry for delays. A few busy weeks. I'll pick this up again through this week. |
Thanks 😄 💃 |
Hi @dvaergiller, |
ping @dvaergiller |
(addresses token revocation by a user #66)
Signed-off-by: Leonardo Rossi leonardo.rossi@studenti.unipr.it