Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 499 error for client closed connections #36

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ssepml
Copy link
Contributor

@ssepml ssepml commented Oct 16, 2024

Description

Define error 499 for client closed requests

@ssepml ssepml requested a review from a team as a code owner October 16, 2024 11:41
@ssepml ssepml force-pushed the ptf-1270-ctx-canceled-error branch from decb2a5 to a700679 Compare October 16, 2024 11:42
api-errors.json Outdated
@@ -643,6 +643,10 @@
"short_message": "Unavailable For Legal Reasons",
"long_message": "Unavailable For Legal Reasons"
},
"49900": {
"short_message": "Client Closed Request",
"long_message": "Client Closed Request"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have a longer description here e.g.

Suggested change
"long_message": "Client Closed Request"
"long_message": "Client closed the connection before the server answered the request"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@ssepml ssepml force-pushed the ptf-1270-ctx-canceled-error branch from a700679 to 8588d2e Compare October 16, 2024 12:59
@ssepml ssepml merged commit 82afe36 into main Oct 16, 2024
2 checks passed
@ssepml ssepml deleted the ptf-1270-ctx-canceled-error branch October 16, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants