Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Nix for CI. #338

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Use Nix for CI. #338

merged 1 commit into from
Nov 29, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 29, 2023

No description provided.

@github-actions
Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-f4abd95 448.5 ± 10.2 434.7 471.8 2.91 ± 0.20
./bench.sh ./comrak-main 463.3 ± 19.5 443.3 514.9 3.00 ± 0.23
./bench.sh ./pulldown-cmark 154.2 ± 9.8 143.5 188.8 1.00
./bench.sh ./cmark-gfm 158.6 ± 7.2 149.9 183.4 1.03 ± 0.08
./bench.sh ./markdown-it 763.3 ± 26.4 711.1 809.9 4.95 ± 0.36

Run on Tue Aug 29 01:32:07 UTC 2023

@charlottia @kivikakk
flake.nix, workflows: use Nix for clippy/fmt to start.
270c6ee 
Some of the clippy checks that fail with `--deny warnings` are likely
overzealous for our MSRV, but need to check.
@kivikakk kivikakk marked this pull request as ready for review November 29, 2023 04:17
@kivikakk
Copy link
Owner

Merging mostly so I can nix develop and work on Comrak again easily — remainder of any CI conversion (if any!) to be done later.

@kivikakk kivikakk merged commit 0679810 into main Nov 29, 2023
24 checks passed
@kivikakk kivikakk deleted the nix branch November 29, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kivikakk @charlottia