Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial badge journey modal #5609

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: initial badge journey modal #5609

wants to merge 7 commits into from
+444 −77

Conversation

dyersituations
Copy link
Collaborator

https://kiva.atlassian.net/browse/MP-838

For the sake of collab with the other engineers working on MyKiva, putting up some progress on the journey modal.

  • Badge journey implemented with arrows for desktop + modal
  • Integrated modal content with badge modal

Work coming next:

  • Integrate with achievements section data
  • Different visual states of badge in journey
  • Captions + buttons in journey
  • Unit testing for new composables
  • Other composable cleanup/comments

image

image

@roger-in-kiva
Copy link
Collaborator

Looks good!
Have you added a ticket for upcoming work?

@dyersituations
Copy link
Collaborator Author

Looks good! Have you added a ticket for upcoming work?

No, I'm keeping the same ticket open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian14b christian14b christian14b approved these changes

@roger-in-kiva roger-in-kiva roger-in-kiva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dyersituations @roger-in-kiva @christian14b