Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: various fixes for form inputs and /register/social MP-938 #5605

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

emuvente
Copy link
Collaborator

I found various issues when completing some checkouts in dev, one using a guest account and another using a new signup.

  • form input error messages were showing when they shouldn't. I found all the cases where checks for $error had been switched to $invalid and switched them back.
  • the first name input was always displaying on /register/social, even when it was not required. looks like that was due to a line for debugging that was left in.
  • it's possible to click "complete registration" multiple times, but only the first request will succeed. Clicking the button cancels the in-flight request and starts a new one, which will end in being sent to the error page. I added a loading overlay so that none of the form can be interacted with after the button is clicked.
  • I found a case of KvBaseInput usage where classes were still being applied directly instead of to a wrapper
  • I replaced the loading spinner in the loading overlay with the one from kv-components:
Screen.Recording.2024-10-16.at.2.04.54.PM.mov

@emuvente emuvente changed the title various fixes for form inputs and /register/social MP-938 feat: various fixes for form inputs and /register/social MP-938 Oct 16, 2024
@emuvente emuvente merged commit c39d113 into main Oct 16, 2024
5 of 6 checks passed
@emuvente emuvente deleted the base-input-fixes branch October 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants