Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass null instead of all, which is not an enum option, in team l… #5568

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

mcstover
Copy link
Collaborator

@mcstover mcstover commented Oct 1, 2024

…eaderboard category field

Copy link
Contributor

@eddieferrer eddieferrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think there might still be a bug on this page when changing to a category and then changing back to "All Categories" the query params do not seem to update

@mcstover
Copy link
Collaborator Author

mcstover commented Oct 1, 2024

@eddieferrer that's likely as the TeamListing file has a large chunk of if statements which all return so some query params may not get updated if earlier conditions are hit...

@mcstover mcstover merged commit 1e3f891 into main Oct 1, 2024
5 checks passed
@mcstover mcstover deleted the fix-null-team-leaderboard-query branch October 1, 2024 17:05
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants