Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing const for prometheus middleware #5096

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: missing const for prometheus middleware #5096

merged 1 commit into from
Dec 8, 2023

Conversation

hobbsh
Copy link
Contributor

@hobbsh hobbsh commented Dec 8, 2023

Missed initializing promBundle in server/index.js.

mcstover
mcstover approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh just missed the import.

@mcstover mcstover merged commit 0e5ffdd into main Dec 8, 2023
5 checks passed
@mcstover mcstover deleted the fix-middleware branch December 8, 2023 20:34
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.723.0-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.723.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcstover mcstover mcstover approved these changes

@emuvente emuvente emuvente approved these changes

@dyersituations dyersituations dyersituations approved these changes

Assignees
No one assigned
Labels
released on @staging released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hobbsh @kiva-robot @mcstover @emuvente @dyersituations