Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prometheus metrics #5095

Merged
merged 1 commit into from
Dec 8, 2023
Merged

feat: add prometheus metrics #5095

merged 1 commit into from
Dec 8, 2023

Conversation

hobbsh
Copy link
Contributor

@hobbsh hobbsh commented Dec 8, 2023

Adds Prometheus metrics via express-prom-bundle (wrapper for prom-client).

To test, spin up the dev server and hit /metrics.

Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, do you have a config pr for flux too? And markeplace-web-ui-ci once we verify, so we can add to current production deploys...

@hobbsh
Copy link
Contributor Author

hobbsh commented Dec 8, 2023

Things should be setup already to scrape via a ServiceMonitor.

@hobbsh hobbsh merged commit e0b5c83 into main Dec 8, 2023
5 checks passed
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.723.0-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.723.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants