feat: create donation banner type #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcstover
reviewed
Dec 5, 2023
| v-kv-track-event="['promo', 'click-other', 'DonationBanner', 0, 0]" | ||
| variant="secondary" | ||
| class="other-amount" | ||
| :href="`/donate/supportus??dfmode=${frequency}&dfmat=0.00`" |
mcstover
reviewed
Dec 5, 2023
| ]" | ||
| variant="secondary" | ||
| class="tw-border-brand tw-text-brand" | ||
| :href="`/donate/supportus/?dfmode=${frequency}& |
| v-if="bannerImageUrl" | ||
| class="tw-absolute tw-h-full tw-w-full tw-z-1" | ||
| :contentful-src="bannerImageUrl" | ||
| alt="" |
There was a problem hiding this comment.
Should we add an alt here?
| 'promo', | ||
| 'click-donation-banner-close', | ||
| 'x', | ||
| ]" class="` |
There was a problem hiding this comment.
The attributes should go on newlines
| v-kv-track-event="[ | ||
| 'promo', | ||
| 'click-donation-banner-close', | ||
| 'x', |
There was a problem hiding this comment.
Is this an appropriate value here?
emuvente
approved these changes
Dec 13, 2023
|
🎉 This PR is included in version 2.724.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.724.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Donation Banner type work