feat: lend menu buttons test code removed #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
roger-in-kiva
commented
Nov 22, 2023
roger-in-kiva
commented
- lend menu buttons old test code removed
| </template> | ||
|
|
||
| <template v-else> | ||
| <template> |
There was a problem hiding this comment.
template can probably be removed, since it's always visible.
dyersituations
approved these changes
Nov 22, 2023
roger-in-kiva
deleted the
CORE-1622_remove_lend_menu_button_test_code
branch
kiva-robot
added a commit
that referenced
this pull request
Dec 7, 2023
## [2.723.0-rc.1](v2.722.0...v2.723.0-rc.1) (2023-12-07) ### 🎉 New Features * add education placement in borrower profile based on region ([2c22a0e](2c22a0e)) * add some test ids to target in robot tests ([7096d88](7096d88)) * add tests ids to portfolio elements ([2bcb7b5](2bcb7b5)) * adding test id to bonus history ([9808860](9808860)) * change portfolio cta art ([3f8dbc5](3f8dbc5)) * hide loan upsell for donation-only baskets ([694c655](694c655)) * homepage file cleaned up ([#5079](#5079)) ([c5c8261](c5c8261)) * lend menu buttons test code removed ([#5078](#5078)) ([d37a627](d37a627)) * loan comment modal added to portfolio page ([#5075](#5075)) ([9a47cde](9a47cde)) * matched loans filter added to filter page ([#5073](#5073)) ([cbc085b](cbc085b)) * mobile filter cta copy updated in filter page ([#5071](#5071)) ([c777c7b](c777c7b)) * supply donate cta test code removed ([#5076](#5076)) ([249e2c6](249e2c6)) * tip rate optimization test code removed ([#5077](#5077)) ([d609987](d609987)) ### 🐛 Bugfixes * change variant variable ([af90786](af90786)) * experiment flag default value ([863e505](863e505)) * generalize the donation tag line when no loans in basket ([8f42e60](8f42e60)) * guard against missing fields and draft ui-global-promo banners ([dfa8c8e](dfa8c8e)) * only reference loans if there are loans in the basket ([80ba549](80ba549)) * temporarily increase prod pod count and request capacity ([0e11c9d](0e11c9d)) * text should be shown for all time leaderboard ([2468c72](2468c72)) ### 🏗️ Build System * pass along release environment variable ([07a7cd8](07a7cd8))
|
🎉 This PR is included in version 2.723.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kiva-robot
added a commit
that referenced
this pull request
Dec 13, 2023
## [2.723.0](v2.722.0...v2.723.0) (2023-12-13) ### 🎉 New Features * add education placement in borrower profile based on region ([2c22a0e](2c22a0e)) * add prometheus metrics ([adb7872](adb7872)) * add some test ids to target in robot tests ([7096d88](7096d88)) * add tests ids to portfolio elements ([2bcb7b5](2bcb7b5)) * adding test id to bonus history ([9808860](9808860)) * change portfolio cta art ([3f8dbc5](3f8dbc5)) * **FakeAuthentication:** use headers for fake auth instead of url parameters CP-677 ([33fb71f](33fb71f)) * hide loan upsell for donation-only baskets ([694c655](694c655)) * homepage file cleaned up ([#5079](#5079)) ([c5c8261](c5c8261)) * lend menu buttons test code removed ([#5078](#5078)) ([d37a627](d37a627)) * loan comment modal added to portfolio page ([#5075](#5075)) ([9a47cde](9a47cde)) * matched loans filter added to filter page ([#5073](#5073)) ([cbc085b](cbc085b)) * mobile filter cta copy updated in filter page ([#5071](#5071)) ([c777c7b](c777c7b)) * supply donate cta test code removed ([#5076](#5076)) ([249e2c6](249e2c6)) * tip rate optimization test code removed ([#5077](#5077)) ([d609987](d609987)) * update events when user clicks No donation and enters /bin/zsh in the custom amount box ([1b9f6d9](1b9f6d9)) ### 🐛 Bugfixes * change variant variable ([af90786](af90786)) * experiment flag default value ([863e505](863e505)) * generalize the donation tag line when no loans in basket ([8f42e60](8f42e60)) * guard against missing fields and draft ui-global-promo banners ([dfa8c8e](dfa8c8e)) * missing const for prometheus middleware ([3d5d5c9](3d5d5c9)) * only reference loans if there are loans in the basket ([80ba549](80ba549)) * temporarily increase prod pod count and request capacity ([0e11c9d](0e11c9d)) * text should be shown for all time leaderboard ([2468c72](2468c72)) ### 🏗️ Build System * pass along release environment variable ([07a7cd8](07a7cd8)) ### 🪚 Refactors * more comprehensible zero_upsell expire calculation ([368c8d8](368c8d8)) ### 🧹 Chores * **release:** 2.723.0-rc.1 [skip ci] ([678f197](678f197)), closes [#5079](#5079) [#5078](#5078) [#5075](#5075) [#5073](#5073) [#5071](#5071) [#5076](#5076) [#5077](#5077) * **release:** 2.723.0-rc.2 [skip ci] ([091f2fe](091f2fe))
|
🎉 This PR is included in version 2.723.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.