Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change query param on new teams page #5059

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

eddieferrer
Copy link
Contributor

Changes the query param for teams categories from teamCategory=something to category=something on the /teams page.

This is needed because there are some links in the legacy teams pages that are linking to /teams?category=something so instead of fixing all the legacy link, lets just make this query param the same.

Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing we haven't rolled out usage of the newer incorrect param key...

@eddieferrer
Copy link
Contributor Author

Guessing we haven't rolled out usage of the newer incorrect param key...

Nope, just internally on the page, set from the dropdown

@eddieferrer eddieferrer merged commit 88f80e5 into main Nov 6, 2023
5 checks passed
@eddieferrer eddieferrer deleted the teams_query_param_fix branch November 6, 2023 17:03
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

2 similar comments
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants