feat: teams page tweaks #5054
Merged
feat: teams page tweaks #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
roger-in-kiva
commented
Oct 31, 2023
roger-in-kiva
commented
- Change the amounts format to show the full number in the leaderboards, seeing the exact number is more valuable.
- Add some helper text to the first two tabs in the leaderboard member counts like this: “Only members who have lent at least once are counted”
- Hide the text "We loan because:" if the field is empty
roger-in-kiva
changed the title
roger-in-kiva
changed the title
mcstover
reviewed
Oct 31, 2023
| @@ -161,6 +161,7 @@ | |||
| > | |||
| <p | |||
| class="tw-text-small tw-text-primary tw-flex-1" | |||
| v-if="shortLoanBecause(team.loanBecause)" | |||
There was a problem hiding this comment.
I think you should just check team.loanBecausehere instead of pushing it through the truncation method.
mcstover
approved these changes
Oct 31, 2023
dyersituations
approved these changes
Oct 31, 2023
eddieferrer
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.