Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: loan tags test code removed #5039

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat: loan tags test code removed #5039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/components/LoansByCategory/HelpmeChoose/HelpmeChooseWrapper.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ export default {
type: Boolean,
default: true
},
enableLoanTags: {
type: Boolean,
default: false
},
enableFiveDollarsNotes: {
type: Boolean,
default: false
Expand Down
6 changes: 0 additions & 6 deletions src/pages/Lend/LoanChannelCategoryControl.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
:loans="helpMeChooseLoans"
@update="getHelpMeChooseLoans($event)"
:is-loading="isLoadingHC"
:enable-loan-tags="enableLoanTags"
:enable-five-dollars-notes="enableFiveDollarsNotes"
/>
</div>
Expand Down Expand Up @@ -123,7 +122,6 @@
:loans="helpMeChooseLoans"
@update="getHelpMeChooseLoans($event)"
:is-loading="isLoadingHC"
:enable-loan-tags="enableLoanTags"
:enable-five-dollars-notes="enableFiveDollarsNotes"
/>
</div>
Expand Down Expand Up @@ -261,10 +259,6 @@ export default {
};
},
props: {
enableLoanTags: {
type: Boolean,
default: false
},
enableFiveDollarsNotes: {
type: Boolean,
default: false
Expand Down
24 changes: 2 additions & 22 deletions src/pages/Lend/LoanChannelCategoryPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
:gray-background="pageLayout === 'control'"
>
<loan-channel-category-control
:enable-loan-tags="enableLoanTags"
:enable-five-dollars-notes="enableFiveDollarsNotes"
/>

Expand Down Expand Up @@ -65,10 +64,8 @@ export default {
return Promise.reject({ path: `/lend-category-beta/${category}`, query });
}

return Promise.all([
client.query({ query: experimentAssignmentQuery, variables: { id: 'loan_tags' } }),
client.query({ query: experimentAssignmentQuery, variables: { id: FIVE_DOLLARS_NOTES_EXP } }),
]);
// eslint-disable-next-line max-len
return client.query({ query: experimentAssignmentQuery, variables: { id: FIVE_DOLLARS_NOTES_EXP } });
});
}
},
Expand All @@ -80,9 +77,6 @@ export default {
// Add to Basket Interstitial
this.initializeAddToBasketInterstitial();

// Initialize Loan Tags Experiment
this.initializeLoanTags();

this.initializeFiveDollarsNotes();
},
mounted() {
Expand All @@ -97,20 +91,6 @@ export default {
}
},
methods: {
initializeLoanTags() {
const loanTagsExperiment = this.apollo.readFragment({
id: 'Experiment:loan_tags',
fragment: experimentVersionFragment,
}) || {};
this.enableLoanTags = loanTagsExperiment.version === 'b';
if (loanTagsExperiment.version) {
this.$kvTrackEvent(
'Lending',
'EXP-CORE-792-Oct2022',
loanTagsExperiment.version
);
}
},
initializeAddToBasketInterstitial() {
this.apollo.mutate({
mutation: updateAddToBasketInterstitial,
Expand Down
Loading