Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove deprecated contentfulUtils #3397

Merged
merged 1 commit into from
Nov 5, 2021
Merged

refactor: remove deprecated contentfulUtils #3397

merged 1 commit into from
Nov 5, 2021

Conversation

eddieferrer
Copy link
Contributor

  • removed processContent and determineResponsive image size functions

VUE-814

refactor: remove deprecated contentfulUtils
da591b5 
* removed processContent and determineResponsive image size functions

VUE-814
mcstover
mcstover approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@mcstover mcstover left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine... I believe the default page is still reachable by an experiment force url but no one expressed intent to continue using it...

...and cheers for the code cleanup!

@eddieferrer
Copy link
Contributor Author

Yeah I think we're good here. LendByCategoryHomepage.vue is not being used. DefaultHomepage will still load with the covid hero.

@eddieferrer eddieferrer merged commit e56c0cb into master Nov 5, 2021
@eddieferrer eddieferrer deleted the VUE-814_processContent_cleanup branch November 5, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcstover mcstover mcstover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddieferrer @mcstover