Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix rendering of empty paragraph tags in RTF #3372

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

eddieferrer
Copy link
Contributor

  • Sometimes contentful will add annoying empty paragraph tags in the rendered content from RTF's. This filters those out, but keeps empty paragraphs in the middle of the content

VUE-791

* Sometimes contentful will add annoying empty paragraph tags in the rendered content from RTF's. This filters those out, but keeps empty paragraphs in the middle of the content

VUE-791
Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good fix for the issue. We will want to review some of our productionized pages though in Dev to see how they are affected by this change.

In particular all of the recent Cause work and the Homepage.

@eddieferrer
Copy link
Contributor Author

I've been working with this fix locally for a little bit. Here are some example differences --
This fix on left, existing pages on right
Screen Shot 2021-10-27 at 10 37 23 AM

Screen Shot 2021-10-27 at 10 39 03 AM

Screen Shot 2021-10-27 at 10 39 28 AM

Note - you can still manually add space in the RTF field by using a soft break (shift+enter)

@eddieferrer
Copy link
Contributor Author

@mcstover @BoulderBrains see samples above ^

@mcstover
Copy link
Collaborator

Thanks @eddieferrer for the additional verification. We'll likely need to go through and smooth over some spacing with our verticalPadding configs in contentful.

@eddieferrer eddieferrer merged commit d34e34e into master Oct 27, 2021
@eddieferrer eddieferrer deleted the VUE-791_fix_empty_p_tags_in_RTF branch October 27, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants