Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes FAQs on pages that use ContentfulPage #3364

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

eddieferrer
Copy link
Contributor

  • Adds a wrapper component that can be used in conjunction with KvFrequentlyAskedQuestions for contentful pages

VUE-790

Fixes FAQ section wrapping for pages that use Contentful page and FAQs (for example lp/climatechange). With this PR, you can either use:
Contentful/FrequentlyAskedQuestions.vue

  • Will wrap the FAQ section with a page container with a max width and a section background

or KvFrequentlyAskedQuestions

  • Will not wrap questions, and you will not be able to apply a sections background (I checked all uses of this in one off pages like /donate/supportus and non of them use the section background anyway)

* Adds a wrapper component that can be used in conjunction with KvFrequentlyAskedQuestions for contentful pages

VUE-790
@eddieferrer
Copy link
Contributor Author

This should be hotfixed or we should hotfix a revert to #3328 since it is affecting the landing pages for the causes MVP.

Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eddieferrer eddieferrer merged commit 44e003f into master Oct 26, 2021
@eddieferrer eddieferrer deleted the VUE-790_FAQ_contentful_fix branch October 26, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants