Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes gradient at bottom of image storycards #3347

Merged
merged 1 commit into from
Oct 20, 2021
Merged

fix: fixes gradient at bottom of image storycards #3347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Contentful/StoryCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
v-if="hasBackgroundImage"
>
<kv-contentful-img
class="tw-h-full tw-w-full tw-object-cover"
class="kv-contentful-img tw-h-full tw-w-full tw-object-cover"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this make things work in Safari and FF? Seems like we would need adjustments to the css to make that work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this works across all browsers. The issue was just that the old component in /ui had this class, and the new component in kv-ui-elements does not have this class

:width="520"
fallback-format="jpg"
:contentful-src="backgroundImage.url"
Expand Down