Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core 158 #3334

Merged
merged 5 commits into from
Oct 15, 2021
Merged

Core 158 #3334

merged 5 commits into from
Oct 15, 2021

Conversation

BoulderBrains
Copy link
Contributor

Core-158

Adding previous loan text to borrower profile if a previousLoanId is returned for the borrower.
Data fetch isn't called unless a user clicks the link to expand the section.

Added a couple small animation on open of this section, Chevron rotates and section expands and closed accordingly.

158

Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BoulderBrains It seems like we don't need the original loanId passed down through LoanDescription into the PreviousLoanDescription component.

@BoulderBrains
Copy link
Contributor Author

@BoulderBrains It seems like we don't need the original loanId passed down through LoanDescription into the PreviousLoanDescription component.

@mcstover
Isn't it needed for the tracking event on line 5 in PreviousLoanDescription.vue?
v-kv-track-event="['Borrower profile', 'click-Loan details', 'Show previous loan details', this.loanId]"

@BoulderBrains BoulderBrains merged commit 91d4909 into master Oct 15, 2021
@BoulderBrains BoulderBrains deleted the Core-158 branch October 15, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants