Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sets index of loanCarousel to 0 when new category is clicked, al… #3298

Merged
merged 1 commit into from
Oct 5, 2021
Merged

fix: sets index of loanCarousel to 0 when new category is clicked, al… #3298

merged 1 commit into from
Oct 5, 2021

Conversation

BoulderBrains
Copy link
Contributor

…so re-initializes to ensure proper number of indexes is displayed below category arrow

  • Core-136
    • When user chooses new category, loan cards are staying on previously scrolled to index.
    • FIXED by setting the index to 0 by calling goToIndex() in KvCarousel
  • Core-137
    • On production, if one category has 4 carousel clicks of loans then 4 will show for all categories even if that category only has 2 "carousel clicks.
    • Results in this error:
    • Screen Shot 2021-10-04 at 2 13 32 PM
    • FIXED by calling the reInit() function

@BoulderBrains
fix: sets index of loanCarousel to 0 when new category is clicked, al…
e2fa406 
…so reinitializes to ensure proper number of indexs is displayed below category arrow
emuvente
emuvente approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@emuvente emuvente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BoulderBrains BoulderBrains merged commit 457049c into master Oct 5, 2021
@BoulderBrains BoulderBrains deleted the CORE-136 branch October 5, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-ludwig ryan-ludwig ryan-ludwig approved these changes

@mcstover mcstover mcstover approved these changes

@emuvente emuvente emuvente approved these changes

@eddieferrer eddieferrer Awaiting requested review from eddieferrer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BoulderBrains @ryan-ludwig @mcstover @emuvente