Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get started redirect link fix and message centering using foundation align-self-middle class #1954

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

BoulderBrains
Copy link
Contributor

PR addressing these concerns:

  • this is causing an error. Should be:
    :to="'/lend-by-category'"
  • The design calls for this text to be vertically centered in the section.
    • I've added the foundation class .align-self-middle, which once the carousel has a height, it should correctly vertically center the text as the design shows.

@eddieferrer
Copy link
Contributor

eddieferrer commented Jul 31, 2020

I did not test this. I have a feeling that the vertical alignment might not work because the carousel doesn't just have a straightforward height value.

lets merge it in and verify

@BoulderBrains BoulderBrains merged commit 921bb16 into master Jul 31, 2020
@BoulderBrains BoulderBrains deleted the get-started-link branch August 1, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants