Skip to content

Commit

Permalink
fix: always evaluate if user landed on a us loan
Browse files Browse the repository at this point in the history
  • Loading branch information
Christian Bedon committed Jun 21, 2024
1 parent 8a5819d commit d7676a4
Showing 1 changed file with 14 additions and 12 deletions.
26 changes: 14 additions & 12 deletions src/pages/Thanks/ThanksPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ export default {
goal: null,
showChallengeHeader: false,
enableMayChallengeHeader: false,
showNewTYPage: false,
optedIn: false,
enableShortVersion: false,
};
Expand Down Expand Up @@ -367,6 +366,20 @@ export default {
teamName() {
return this.loans?.[0]?.team?.name ?? '';
},
landedOnUSLoan() {
const bpPattern = /^\/lend\/(\d+)/;
if (bpPattern.test(this.$appConfig.firstPage)) {
const url = this.$appConfig.firstPage?.split('/');
const firstVisitloanId = url?.[2] ?? null;
const landedLoan = this.loans.find(loan => loan.id === Number(firstVisitloanId));
return landedLoan?.geocode?.country?.isoCode === 'US';
}
return false;
},
showNewTYPage() {
return !this.landedOnUSLoan && (this.isFirstLoan || this.isGuest) && !this.optedIn;
},
},
created() {
// Retrieve and apply Page level data + experiment state
Expand Down Expand Up @@ -493,17 +506,6 @@ export default {
this.enableMayChallengeHeader = shareChallengeExpData?.version === 'b';
this.optedIn = data?.my?.communicationSettings?.lenderNews || this.$route.query?.optedIn === 'true';
const bpPattern = /^\/lend\/(\d+)/;
if (bpPattern.test(this.$appConfig.firstPage)) {
const url = this.$appConfig.firstPage?.split('/');
const firstVisitloanId = url?.[2] ?? null;
const landedLoan = this.loans.find(loan => loan.id === Number(firstVisitloanId));
this.showNewTYPage = landedLoan?.geocode?.country?.isoCode !== 'US'
&& (isFirstLoan || this.isGuest)
&& !this.optedIn;
}
// New Thanks Page Experiment
if (this.showNewTYPage) {
Expand Down

0 comments on commit d7676a4

Please sign in to comment.