fix: ensure richText content shows for globalPromo banners and hide d…

…isclaimer link when not present
kiva · Nov 23, 2021 · 8001539 · 8001539
1 parent ed7918c
commit 8001539
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/components/WwwFrame/PromotionalBanner/Banners/GenericPromoBanner.vue b/src/components/WwwFrame/PromotionalBanner/Banners/GenericPromoBanner.vue
@@ -9,9 +9,8 @@
 				:target="isExternalLink ? '_blank' : '_self'"
 				:class="{ 'banner-link' : trimmedLink, 'banner-wrapper' : !trimmedLink}"
 				v-kv-track-event="handleTracking"
-			>
-				{{ processedContent }}
-			</component>
+				v-html="processedContent"
+			/>
 			<a
 				v-if="hasDisclaimer"
 				@click="scrollToSection('#disclaimers')"
@@ -95,7 +94,8 @@ export default {
 			return this.promoBannerContent?.link?.trim() ?? '';
 		},
 		hasDisclaimer() {
-			return this.promoBannerContent.disclaimer !== '';
+			const disclaimer = this.promoBannerContent?.disclaimer ?? '';
+			return disclaimer !== '';
 		}
 	},
 };

diff --git a/src/components/WwwFrame/PromotionalBanner/GlobalPromotionalBannerContentful.vue b/src/components/WwwFrame/PromotionalBanner/GlobalPromotionalBannerContentful.vue
@@ -117,10 +117,11 @@ export default {
 						// Promo Banner
 						// parse the contentful richText into an html string
 						this.promoBannerContent = {
+							disclaimer: activePromoBanner?.fields?.disclaimers?.content?.[0] ?? null,
 							kvTrackEvent: activePromoBanner.fields.kvTrackEvent,
 							link: activePromoBanner.fields.link,
 							richText: documentToHtmlString(activePromoBanner.fields.richText),
-							iconKey: _get(activePromoBanner, 'fields.iconKey', 'present')
+							iconKey: _get(activePromoBanner, 'fields.iconKey', 'present'),
 						};
 						this.isPromoEnabled = true;
 					}