Skip to content

Commit

Permalink
fix: resolve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Christian Bedon committed May 23, 2024
1 parent 262a861 commit 5c6d250
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion server/auth-router.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ module.exports = function authRouter(config = {}) {

// Opt-In Communication Exp MP-271
if (cookies.opt_in_comms) {
options.optInComms = 'b';
options.optInComms = true;
}

info(`LoginUI: attempt login, session id:${req.sessionID}, cookie:${getSyncCookie(req)}, done url:${req.query.doneUrl}`); // eslint-disable-line max-len
Expand Down
2 changes: 1 addition & 1 deletion src/components/Checkout/CheckoutDropInPaymentWrapper.vue
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
>Privacy {{ enableCommsExperiment ? 'Notice' : 'Policy' }}</a>.
<p v-if="$v.termsAgreement.$error" class="input-error tw-text-danger tw-text-base">
You must agree to the Kiva Terms of service & Privacy
{{ enableCommsExperiment ? 'notice' : 'policy' }}.
{{ enableCommsExperiment ? 'Notice' : 'Policy' }}.
</p>
</kv-checkbox>
<kv-checkbox
Expand Down
14 changes: 6 additions & 8 deletions src/components/WwwFrame/TheHeader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -800,15 +800,13 @@ export default {
}
}
if (this.cookieStore.get(COMMS_OPT_IN_EXP_KEY) !== 'true') {
const { version } = this.apollo.readFragment({
id: `Experiment:${COMMS_OPT_IN_EXP_KEY}`,
fragment: experimentVersionFragment,
}) ?? {};
const { version } = this.apollo.readFragment({
id: `Experiment:${COMMS_OPT_IN_EXP_KEY}`,
fragment: experimentVersionFragment,
}) ?? {};
if (version === 'b') {
this.cookieStore.set(COMMS_OPT_IN_EXP_KEY, true, { path: '/' });
}
if (version === 'b') {
this.cookieStore.set(COMMS_OPT_IN_EXP_KEY, true, { path: '/' });
}
userHasLentBefore(this.cookieStore.get(hasLentBeforeCookie) === 'true');
Expand Down

0 comments on commit 5c6d250

Please sign in to comment.