feat: Navbar copy and event changes in teams

kiva · May 17, 2024 · 07f6e44 · 07f6e44
1 parent 833f879
commit 07f6e44
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 18 deletions.
diff --git a/src/components/WwwFrame/Header/TeamsMenu.vue b/src/components/WwwFrame/Header/TeamsMenu.vue
@@ -3,12 +3,12 @@
 		<router-link
 			:id="teamMenuId"
 			to="/teams"
-			data-testid="header-teams"
+			data-testid="header-lending-teams"
 			class="header__button tw-inline-flex"
-			v-kv-track-event="['TopNav','click-Teams']"
+			v-kv-track-event="['topnav','click', 'lending-teams']"
 		>
 			<span class="tw-flex">
-				Teams
+				Lending Teams
 				<kv-material-icon
 					v-if="totalTeams"
 					class="tw-w-3 tw-h-3 tw-transition-transform tw-duration-300 group-hover:tw-rotate-180"
@@ -20,14 +20,16 @@
 			v-if="totalTeams"
 			:controller="teamMenuId"
 			class="dropdown-list"
-			data-testid="header-teams-dropdown-list"
+			data-testid="header-lending-teams-dropdown-list"
 		>
 			<ul v-if="totalTeams === 1">
 				<li>
 					<a
 						v-kv-track-event="[
-							'TopNav',
-							'click-Teams-My Team\'s activity',
+							'topnav',
+							'click',
+							'lending-teams',
+							'my-team\'s-activity',
 							`${teamsData[0].team.teamPublicId}`
 						]"
 						:href="`/team/${teamsData[0].team.teamPublicId}`"
@@ -38,33 +40,38 @@
 				<li>
 					<a
 						v-kv-track-event="[
-							'TopNav',
-							'click-Teams-My Team\'s impact',
+							'topnav',
+							'click',
+							'lending-teams',
+							'my-team\'s-impact',
 							`${teamsData[0].team.teamPublicId}`
 						]"
 						:href="`/team/${teamsData[0].team.teamPublicId}/impact`"
 					>
 						My Team's impact
 					</a>
 				</li>
-				<li>
-					<a v-kv-track-event="['TopNav','click-Teams-Join another team']" href="/teams">
-						Join another team
-					</a>
-				</li>
 			</ul>
 			<ul v-else style="width: 9rem;">
 				<li v-for="{ team } in teamsData" :key="team.id">
 					<a
-						v-kv-track-event="['TopNav',`click-Teams-${team.name}`]"
+						v-kv-track-event="['topnav', 'click', 'lending-teams', team.name]"
 						:href="`/team/${team.teamPublicId}`"
 						class="tw-whitespace-nowrap tw-text-ellipsis tw-overflow-hidden"
 					>
 						{{ team.name }}
 					</a>
 				</li>
 				<li v-if="totalTeams > teamsData.length">
-					<a v-kv-track-event="['TopNav','click-Teams-Join another team']" href="/teams/my-teams">
+					<a
+						v-kv-track-event="[
+							'topnav',
+							'click',
+							'lending-teams',
+							'view-all-my-teams'
+						]"
+						href="/teams/my-teams"
+					>
 						View all my teams
 					</a>
 				</li>

diff --git a/test/unit/specs/components/WwwFrame/TeamsMenu.spec.js b/test/unit/specs/components/WwwFrame/TeamsMenu.spec.js
@@ -114,7 +114,7 @@ describe('TeamsMenu', () => {
 		};
 		const { queryByTestId } = renderTeamsMenu(props);
 
-		const anchor = queryByTestId('header-teams');
+		const anchor = queryByTestId('header-lending-teams');
 		expect(anchor.getAttribute('to')).toBe('/teams');
 	});
 
@@ -126,13 +126,11 @@ describe('TeamsMenu', () => {
 
 		const activity = queryByText("My Team's activity");
 		const impact = queryByText("My Team's impact");
-		const join = queryByText('Join another team');
 
 		const { teamPublicId } = props.teams.values[0].team;
 
 		expect(activity.getAttribute('href')).toBe(`/team/${teamPublicId}`);
 		expect(impact.getAttribute('href')).toBe(`/team/${teamPublicId}/impact`);
-		expect(join.getAttribute('href')).toBe('/teams');
 	});
 
 	it('should show 3 teams', async () => {