Skip to content

Commit

Permalink
fix: event names for listeners must be hyphenated
Browse files Browse the repository at this point in the history
  • Loading branch information
emuvente committed Oct 3, 2024
1 parent 7102be7 commit 067e3a7
Show file tree
Hide file tree
Showing 12 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion src/components/BorrowerProfile/LendCta.vue
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
'click-Modify loan amount',
'open dialog'
]"
@update:modelValue="trackLendAmountSelection"
@update:model-value="trackLendAmountSelection"
>
<option
v-for="priceOption in prices"
Expand Down
6 changes: 3 additions & 3 deletions src/components/Checkout/CheckoutDropInPaymentWrapper.vue
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<user-updates-preference
v-if="enableRadioBtnExperiment"
tracking-category="basket"
@update:modelValue="selectedComms = $event"
@update:model-value="selectedComms = $event"
is-checkout
/>
<template v-else>
Expand All @@ -67,7 +67,7 @@
name="termsAgreement"
class="checkbox tw-text-small tw-mb-2"
v-model="termsAgreement"
@update:modelValue="$kvTrackEvent(
@update:model-value="$kvTrackEvent(
'basket',
'click',
'terms-of-use',
Expand Down Expand Up @@ -98,7 +98,7 @@
class="checkbox tw-text-small tw-mb-2"
name="emailUpdates"
v-model="emailUpdates"
@update:modelValue="$kvTrackEvent(
@update:model-value="$kvTrackEvent(
'basket',
'click',
'marketing-updates',
Expand Down
2 changes: 1 addition & 1 deletion src/components/Checkout/DonateRepaymentsToggle.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
data-testid="donate-repayments"
v-if="!myDonateRepayments"
v-model="donateRepayments"
@update:modelValue="setDonateRepayments"
@update:model-value="setDonateRepayments"
>
<span
id="donate-repayments-tooltip"
Expand Down
4 changes: 2 additions & 2 deletions src/components/Checkout/KivaCreditGuestPayment.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
name="termsAgreement"
class="checkbox tw-text-small tw-mb-2"
v-model="termsAgreement"
@update:modelValue="$kvTrackEvent(
@update:model-value="$kvTrackEvent(
'basket',
'click-terms-of-use',
'I have read and agree to the Terms of Use and Privacy Policy.',
Expand Down Expand Up @@ -61,7 +61,7 @@
class="checkbox tw-text-small tw-mb-2"
name="emailUpdates"
v-model="emailUpdates"
@update:modelValue="$kvTrackEvent(
@update:model-value="$kvTrackEvent(
'basket',
'click-marketing-updates',
'Receive email updates from Kiva (including borrower updates and promos). You can unsubscribe anytime.', // eslint-disable-line
Expand Down
2 changes: 1 addition & 1 deletion src/components/Checkout/LoanPrice.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class="loan-price tw-w-full"
style="max-width: 18rem;"
id="loan-price"
@update:modelValue="updateLoanReservation()"
@update:model-value="updateLoanReservation()"
>
<option
v-for="priceOption in prices"
Expand Down
2 changes: 1 addition & 1 deletion src/components/Checkout/TeamAttribution.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
v-model="selectedId"
class="team-select-dd data-hj-suppress tw-float-left"
style="max-width: rem-calc(250);"
@update:modelValue="updateLoanReservation()"
@update:model-value="updateLoanReservation()"
>
<option value="0">
None
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
:items="getItems(region.countries)"
:selected-values="selectedCountries"
@updated="updateCountries($event)"
@closeRegions="toggleRegions()"
@close-regions="toggleRegions()"
/>
</div>
</div>
Expand All @@ -130,7 +130,7 @@
:items="getItems(activeCountries)"
:selected-values="selectedCountries"
@updated="updateCountries($event)"
@closeRegions="toggleRegions()"
@close-regions="toggleRegions()"
/>
<div class="tw-flex tw-gap-2 tw-justify-end">
<button @click="selectedCountries = []" class="tw-text-link">
Expand Down
2 changes: 1 addition & 1 deletion src/components/MonthlyGood/MonthlyGoodSelectorMobile.vue
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
id="mgAmountDropdown"
class="tw-w-full"
v-model.number="mgAmount"
@update:modelValue="trackMgAmountSelection"
@update:model-value="trackMgAmountSelection"
>
<option
v-for="(option, index) in mgAmountOptions"
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Autolending/AutolendingWho.vue
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
<template #controls>
<div class="row">
<div class="columns shrink">
<save-button @autolendingSaved="settingsSaved" />
<save-button @autolending-saved="settingsSaved" />
</div>
<div class="columns" v-show="!kivaChooses">
<inline-counter />
Expand Down
6 changes: 3 additions & 3 deletions src/pages/LendingTeams/TeamListing.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<kv-select
id="category"
v-model="teamCategory"
@update:modelValue="pushChangesToUrl"
@update:model-value="pushChangesToUrl"
v-kv-track-event="['teams', 'filter', 'teams-search', teamCategory]"
>
<option v-for="(category, index) in teamCategories" :key="index" :value="category.value">
Expand All @@ -33,7 +33,7 @@
<kv-select
id="categoryTeams"
v-model="teamOption"
@update:modelValue="pushChangesToUrl"
@update:model-value="pushChangesToUrl"
v-kv-track-event="['teams', 'filter', 'teams-search', teamOption]"
>
<option value="">
Expand All @@ -56,7 +56,7 @@
<div>
<kv-select
id="categorySort" v-model="teamSort"
@update:modelValue="pushChangesToUrl"
@update:model-value="pushChangesToUrl"
>
<!-- <option value="recentActivityScore">
Recent Activity
Expand Down
6 changes: 3 additions & 3 deletions src/pages/LoginAndRegister/RegisterSocial.vue
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
<user-updates-preference
v-if="enableRadioBtnExperiment"
tracking-category="authentication"
@update:modelValue="selectedComms = $event"
@update:model-value="selectedComms = $event"
/>
<input
v-if="enableRadioBtnExperiment"
Expand All @@ -86,7 +86,7 @@
v-show="needsTerms"
v-model="newAcctTerms"
:validation="v$.newAcctTerms"
@update:modelValue="$kvTrackEvent(
@update:model-value="$kvTrackEvent(
'authentication',
'click',
'terms-of-use',
Expand All @@ -111,7 +111,7 @@
type="checkbox"
v-show="needsNews"
v-model="newsConsent"
@update:modelValue="$kvTrackEvent(
@update:model-value="$kvTrackEvent(
'authentication',
'click',
'marketing-updates',
Expand Down
2 changes: 1 addition & 1 deletion src/pages/MonthlyGood/LandingForm.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<kv-select
class="tw-w-full" id="borrower-categories"
:model-value="selectedGroup"
@update:modelValue="updateSelected"
@update:model-value="updateSelected"
>
<option v-for="(option, index) in lendingCategories" :value="option.value" :key="index">
{{ option.label }}
Expand Down

0 comments on commit 067e3a7

Please sign in to comment.